add support for derivative metrics #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 12, 2012 12:27
A derivative metric is like a meter but accepts an absolute counter as input. This is useful for metrics like bytes sent over the network or cpu cycles which are generally monotonically increasing counters and therefore need to be derived from the previous sample to get a useful rate/s value.
| module Metriks | ||
| class Derive < Metriks::Meter | ||
| def mark(val = 1) | ||
| @last ||= Atomic.new(val) |
There was a problem hiding this comment.
This needs to be initialized in the constructor to be threadsafe.
|
I think we should make a derivative metric not inherit from The things to consider are:
With the |
|
In my case:
since i collect these metrics every second, i don't really care about the other two, but i would suggest something like:
probably do it similar to RRDtool, people are already familiar how DERIVE works with RRAs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A derivative metric is like a meter but accepts an absolute counter as
input. This is useful for metrics like bytes sent over the network or
cpu cycles which are generally monotonically increasing counters and
therefore need to be derived from the previous sample to get a useful
rate/s value.